donnemartin / gitsome

A supercharged Git/GitHub command line interface (CLI). An official integration for GitHub and GitHub Enterprise: https://github.com/works-with/category/desktop-tools

Other

7.56k stars 438 forks source link

Fix #147: Gracefully ignore missing avatar image #148

Closed kBite closed 5 years ago

kBite commented 6 years ago

Replacing exit() with return results in displaying the error message in place of the missing avatar image without stopping execution of 'gitsome'.

codecov-io commented 6 years ago

Codecov Report

Merging #148 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   95.07%   95.07%           
=======================================
  Files          34       34           
  Lines        2112     2112           
=======================================
  Hits         2008     2008           
  Misses        104      104

kBite commented 6 years ago

Drawback of this solution is an error message displayed everytime gh is run:

$  gh me
File not found: /home/kbite/.gitsomeconfigavatar.png
Followers: 0 | Following: 0
...

Maybe dropping the error message would be nicer.

donnemartin commented 5 years ago

@kBite thank you!