donnemartin / gitsome

A supercharged Git/GitHub command line interface (CLI). An official integration for GitHub and GitHub Enterprise: https://github.com/works-with/category/desktop-tools

Other

7.56k stars 438 forks source link

Resolves #149: Add option to disable avatar #150

Closed kBite closed 5 years ago

kBite commented 6 years ago

Configuring disable_avatar = True will stop gitsome from requesting avatar images (#149). If disable_avatar option is missing, it's added correctly, thus not breaking existing config files.

$ grep avatar .gitsomeconfig
disable_avatar = True

codecov-io commented 6 years ago

Codecov Report

Merging #150 into master will increase coverage by 0.01%. The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   95.07%   95.09%   +0.01%     
==========================================
  Files          34       34              
  Lines        2112     2119       +7     
==========================================
+ Hits         2008     2015       +7     
  Misses        104      104

donnemartin commented 5 years ago

Hi @kBite thanks for the PR! I left some feedback.

kBite commented 5 years ago

@donnemartin Thanks for your feedback. Going with enable_avatar = True is way more intuitive. So I force pushed updated commits replacing disable_avatar with enable_avatar and removing the unnecessary else lines.

Please review again.

kBite commented 5 years ago

Default was added to .gitcomeconfig

donnemartin commented 5 years ago

@kBite thank you!

Jimimaku commented 1 year ago

Configuring disable_avatar = True will stop gitsome from requesting avatar images (#149). If disable_avatar option is missing, it's added correctly, thus not breaking existing config files.
$ grep avatar .gitsomeconfig
disable_avatar = True