search

donnemartin / gitsome

A supercharged Git/GitHub command line interface (CLI). An official integration for GitHub and GitHub Enterprise: https://github.com/works-with/category/desktop-tools
Other
7.59k stars 439 forks source link

Temporarily skip ssl error test #64

Closed donnemartin closed 8 years ago

donnemartin commented 8 years ago

Temp skipping this test due to a change [undocumented?] in the way the requests ssl error sample website is handled. See: http://docs.python-requests.org/en/master/user/advanced/#ssl-cert-verification

Documented:

requests.exceptions.SSLError: hostname 'requestb.in' doesn't match either of '*.herokuapp.com', 'herokuapp.com'

Results seem to vary from local results:

Error: [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:646)

To no SSL error on Travis:

https://travis-ci.org/donnemartin/gitsome/builds/136669720

codecov-io commented 8 years ago

Current coverage is 95.18%

Merging #64 into master will decrease coverage by 0.33%

  1. File ...itsome/web_viewer.py (not in diff) was modified. more
    • Misses +4
    • Partials 0
    • Hits -4
@@             master        #64   diff @@
==========================================
  Files            34         34          
  Lines          2075       2076     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1982       1976     -6   
- Misses           93        100     +7   
  Partials          0          0

Powered by Codecov. Last updated by 46060cf...da82282