donnemartin / gitsome

A supercharged Git/GitHub command line interface (CLI). An official integration for GitHub and GitHub Enterprise: https://github.com/works-with/category/desktop-tools
Other
7.59k stars 439 forks source link

List dependencies in setup.py instead of embedding #82

Open simon04 opened 8 years ago

simon04 commented 8 years ago

This helps packaging this tool for Linux distributions.

codecov-io commented 8 years ago

Current coverage is 95.18% (diff: 100%)

Merging #82 into master will not change coverage

@@             master        #82   diff @@
==========================================
  Files            34         34          
  Lines          2076       2076          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1976       1976          
  Misses          100        100          
  Partials          0          0          

Powered by Codecov. Last update 9aaccab...d92bb73

donnemartin commented 8 years ago

Hi @simon04, thanks for the PR!

This is something I'd like to move towards. There are some customizations to each dependency in the lib folder that would need to make it back to the main repo for this to be completed.

fzerorubigd commented 8 years ago

The problem is, some of this dependencies are out dated. for example my problem is with uritemplate.py that should be <1.0.0,>=0.2.0 but the current version is 3.0.0 could you please at least update this dependencies?

donnemartin commented 8 years ago

@fzerorubigd I'll see about updating, thanks for the heads up.

donnemartin commented 8 years ago

@fzerorubigd I updated the dependency for uritemplate.py, let's use https://github.com/donnemartin/gitsome/pull/86 for additional discussions.

donnemartin commented 7 years ago

@timofonic sorry been really tied up with work, not sure when this will reach the top of my queue.