Update config path to comply with XDG Base Directory spec

donnemartin / gitsome

A supercharged Git/GitHub command line interface (CLI). An official integration for GitHub and GitHub Enterprise: https://github.com/works-with/category/desktop-tools

Other

7.56k stars 437 forks source link

Update config path to comply with XDG Base Directory spec #90

Open SanketDG opened 7 years ago

SanketDG commented 7 years ago

https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

Issue: https://github.com/donnemartin/gitsome/issues/13

SanketDG commented 7 years ago

I am not sure what else files are used, some help would be appreciated!

codecov-io commented 7 years ago

Current coverage is 95.18% (diff: 100%)

Merging #90 into master will not change coverage

@@             master        #90   diff @@
==========================================
  Files            34         34          
  Lines          2076       2076          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1976       1976          
  Misses          100        100          
  Partials          0          0

Powered by Codecov. Last update eebb2cf...b9994bd

donnemartin commented 7 years ago

Hi @SanketDG, you're on a roll, thanks for the second PR! I'll try to review it this week.

donnemartin commented 7 years ago

Hi, took a closer look...

From https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html:

If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used.

On my system, I don't have $XDG_CONFIG_HOME configured. It seems like we'd have to add additional logic to set the path to $HOME/.config?

Also, curious how this affects Windows.