Refactor conversion of None to empty introduced in #49 and #40

donnemartin / gitsome

A supercharged Git/GitHub command line interface (CLI). An official integration for GitHub and GitHub Enterprise: https://github.com/works-with/category/desktop-tools

Other

7.59k stars 439 forks source link

Refactor conversion of None to empty introduced in #49 and #40 #93

Closed jashgala closed 7 years ago

jashgala commented 7 years ago

Handled refactoring discussed in Issue #52.

Moved check for None to TextUtils and updated the github.py functions to use that instead of directly checking in the function itself.

codecov-io commented 7 years ago

Current coverage is 95.18% (diff: 100%)

Merging #93 into master will increase coverage by <.01%

@@             master        #93   diff @@
==========================================
  Files            34         34          
  Lines          2094       2098     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1993       1997     +4   
  Misses          101        101          
  Partials          0          0

Powered by Codecov. Last update 5a24a9b...845cef8

donnemartin commented 7 years ago

Hi @jashgala, thanks for the PR! I hope to review it this week.

donnemartin commented 7 years ago

@jashgala sorry for the late review, thanks again for the PR.

I've requested some minor tweaks to the docstring.

Also, could you resolve the conflicts?

Thanks!

jashgala commented 7 years ago

Continued in #100

(Changed target branch)