donnemartin / interactive-coding-challenges

120+ interactive Python coding interview challenges (algorithms and data structures). Includes Anki flashcards.
Other
29.44k stars 4.45k forks source link

Added Dockerfile and docker-compose.yml #192

Open cheesesashimi opened 7 years ago

cheesesashimi commented 7 years ago

For those who are unfamiliar with iPython and it's workflow, it can be a bit daunting if you just want to do some coding challenges, especially for new developers. With that in mind, I've provided a Dockerfile and docker-compose.yml to help get things up and running faster.

In most cases, users will just have to run $ docker-compose up and copy / paste the URL it provides to get up and running. I've included some additional context in the README.md file as well.

I hope others find this useful!

eamanu commented 7 years ago

That sound great

donnemartin commented 7 years ago

Hi @cheesesashimi, this sounds great, thanks for the pull request!

Any docker users that could help with reviewing?

iabok commented 7 years ago

@donnemartin sure :+1:

eamanu commented 7 years ago

Hi @cheesesashimi,

Great work!

I have some changes that you must add to realize a correct Merge. First, I had to install Docker, you should explain this steps, or link to a tutorial. Second, You should add into requeriments.txt the docker-py module, because I had to install this python module. Fourth, you have to warning that the process take it time, Are not there some solution that you not have to wait many time?

Finally I have this error:

...
Removing intermediate container 38d27d736b5d
Successfully built 63474fe46540
Successfully tagged interactivecodingchallenges_jupyter-challenge:latest
WARNING: Image for service jupyter-challenge was built because it did not already exist. To rebuild this image you must use `docker-compose build` or `docker-compose up --build`.
Creating interactivecodingchallenges_jupyter-challenge_1 ... 
Creating interactivecodingchallenges_jupyter-challenge_1 ... done
Attaching to interactivecodingchallenges_jupyter-challenge_1
**jupyter-challenge_1  | [FATAL tini (7)] Executing child process '/notebook/start_notebook.sh' failed: 'No such file or directory'
interactivecodingchallenges_jupyter-challenge_1 exited with code 1**

@donnemartin I don't know if Docker is necessary for the project because this don't require a powerful continuous integration. Using Docker will add complexity unnecessary.

Regards!

marcraminv commented 6 years ago

Hi @cheesesashimi, from my point of view the idea is fantastic because no one has to mess the local environment with that, but some points.