Solution to the Longest Common Subsequence needs corrections

donnemartin / interactive-coding-challenges

120+ interactive Python coding interview challenges (algorithms and data structures). Includes Anki flashcards.

Other

29.44k stars 4.45k forks source link

Solution to the Longest Common Subsequence needs corrections #209

Open Code-ScottLe opened 7 years ago

Code-ScottLe commented 7 years ago

The current solution could be spooked with 2 inputs : "ABCDFE" and "FOOBCDBCDE". The logic will create a map that will still end up having the last letter E in sequence.

According to Wikipedia , they are filling in 0 instead of taking the max (left, above) for characters that aren't matched.

sumuksr2 commented 5 years ago

Hi! My name is Sumuk and I'm interested in working on this open source project and I hope to start by working on this issue. Please let me know how I can get started and what I will need to read to begin on this project.