Fixed links of all questions. - Githubissues

donnemartin / interactive-coding-challenges

120+ interactive Python coding interview challenges (algorithms and data structures). Includes Anki flashcards.

Other

29.44k stars 4.45k forks source link

Fixed links of all questions. #215

Closed ShantanuKamath closed 6 years ago

ShantanuKamath commented 7 years ago

@donnemartin Please review this

ShantanuKamath commented 7 years ago

Hi @donnemartin, Updated all of iPython Notebooks to have the correct link in the solutions link. Please review!

ShantanuKamath commented 7 years ago

Hi @donnemartin will look into them!

ShantanuKamath commented 7 years ago

Hi @donnemartin is this okay? I've squashed the commits into 1 and removed all the extra metadata. Used a package called nbstripout. Its stripped more than what was added by me. But maybe you can consider keeping files like that now? Do see the git diffs.

ShantanuKamath commented 7 years ago

So what it has essentially done is:

Added a solution link, wherever missing or wrong.
Cleaned the notebooks to keep out all the extra metadata. Which in this case refers to the json keys that refer to keeping counts of execution and the outputs of the data. On referring to the way git and IPython NB are maintained by keeping only the source code and no account of the cells run or their outputs. There is module called nbstripout that does just this. https://pypi.python.org/pypi/nbstripout/0.2.0 Hope that clears it out?

ShantanuKamath commented 6 years ago

Any update on this? @donnemartin

donnemartin commented 6 years ago

There are too many extraneous changes in this diff. The only changes that should show up are the relevant link changes.

eamanu commented 6 years ago

Try with a new PR, with the correct commit @ShantanuKamath

ShantanuKamath commented 6 years ago

Okay will try again! :)