search

donnemartin / saws

A supercharged AWS command line interface (CLI).
Other
5.23k stars 280 forks source link

[WIP] Upgrade to prompt_toolkit 2.0 #104

Open jonathanslenders opened 6 years ago

jonathanslenders commented 6 years ago

TODO: check the ignore_case parameter.

jonathanslenders commented 6 years ago

See also: https://github.com/jonathanslenders/python-prompt-toolkit/issues/568 and: https://github.com/jonathanslenders/python-prompt-toolkit/pull/446

jeffbyrnes commented 6 years ago

@jonathanslenders you might want to check #68. tl;dr, this project is deprecated in favor of aws-shell.

jonathanslenders commented 6 years ago

OK. I'll see whether I can send a similar pull request to aws-shell. Thanks for the pointer!

xorb0ss commented 5 years ago

I don't agree with @jeffbyrnes here. aws-shell seems much more abandoned than this. Anyway, I just stumbled upon saws and found problems with this PR.

I've fixed them on my end with some minor changes - see #114

jeffbyrnes commented 5 years ago

I mean, it’s… not an opinion of mine; at the time I posted that, the maintainer of SAWS (@donnemartin) appeared to have decided to work with the aws-shell folks & merge the projects (per the issue I referenced).

The aws-shell project is also Officially Supported™ by AWS, so that seems like a good thing? Not that they’re doing very much of that.

But honestly, you’re right that SAWS has seen more activity; aws-shell hasn’t been updated since Sep 21, 2018, per its project repo. OSS is hard? 🤷‍♂

xorb0ss commented 5 years ago

My bad, I hadn't looked at #68. Personal preference too, but having used aws-shell, I prefer saws. Not sure why that is though :-)

jeffbyrnes commented 3 years ago

Going through old issues I’m in, and giving this one a bump to either merge, or close, since it’s > 1 yr old.