search

donnemartin / saws

A supercharged AWS command line interface (CLI).
Other
5.24k stars 281 forks source link

Changes to be compatible with prompt-toolkit=0.52 #30

Closed jonathanslenders closed 8 years ago

jonathanslenders commented 8 years ago

There are a few backward incompatible changes in prompt-toolkit 0.52. I don't recommend supporting both the latest and previous versions. This pull request makes the required changes to keep everything working like it was.

One additional change is that mouse support is on. Feel free to change the pull request to disable mouse support.

donnemartin commented 8 years ago

Hi Jonathan,

Thanks for the pull request, I just pushed a temp fix on PyPI for https://github.com/donnemartin/saws/issues/29 by scoping prompt-toolkit to <= 0.50.

I'll take a look at the pull request.

-Donne

codecov-io commented 8 years ago

Current coverage is 96.17%

Merging #30 into master will not affect coverage as of e9b2015

@@            master     #30   diff @@
======================================
  Files           19      19       
  Stmts         1046    1047     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1006    1007     +1
  Partial          0       0       
  Missed          40      40

Review entire Coverage Diff as of e9b2015

Powered by Codecov. Updated on successful CI builds.

donnemartin commented 8 years ago

Thanks for the fix Jonathan. I couldn't get the hang of the new mouse click behavior so I've disabled it for now. I'll try to play around with it some more.