search

donnemartin / saws

A supercharged AWS command line interface (CLI).
Other
5.24k stars 281 forks source link

Fix grep not working because of bug finding the word following %s #45

Closed mlimaloureiro closed 8 years ago

mlimaloureiro commented 8 years ago

@donnemartin any tips on what needs to be done to pass the checks on codecov and appveyor?

donnemartin commented 8 years ago

@mlimaloureiro thanks for the pull request, I'll try to check it out in the next day or so.

Regarding Appveyor, there seem to be issues with running SAWS on it, I've disabled it for now. I think the codecov errors are related and should go away with Appveyor disabled.

donnemartin commented 8 years ago

@mlimaloureiro just wanted to touch base and let you know I haven't forgotten about this :)

I'm still working on the refactor and trying to get that wrapped up, then I'll be more free to look at bug fixes and new features.

donnemartin commented 8 years ago

@mlimaloureiro I've been making heavy refactor changes recently which introduced merge conflicts for this PR--fortunately they seem straightforward. In your next PR could you please address them? Thanks!

mlimaloureiro commented 8 years ago

no worries tomorrow i'll solve the conflicts

codecov-io commented 8 years ago

Current coverage is 94.57%

Merging #45 into master will decrease coverage by -0.14% as of c75c2df

@@            master     #45   diff @@
======================================
  Files           29      29       
  Stmts         1211    1235    +24
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1147    1168    +21
  Partial          0       0       
- Missed          64      67     +3

Review entire Coverage Diff as of c75c2df

Powered by Codecov. Updated on successful CI builds.

mlimaloureiro commented 8 years ago

@donnemartin solved conflicts and refactored

donnemartin commented 8 years ago

@mlimaloureiro thanks for the changes. I'll try to do another review tonight or tomorrow at the latest and get this merged.

donnemartin commented 8 years ago

Sorry for the delay, been busy at re:Invent, I should have this reviewed/merged by the weekend.

donnemartin commented 8 years ago

@mlimaloureiro thanks for your contribution!