Open harsh-batheja opened 2 years ago
I’ve opened a pr.
Otherwise you can also use "Dark dimmed" github theme
It doesn't quite work for me, it's not dark enough and the text then too looks quite bad on it.
On Wed, 5 Jan 2022, 5:47 am vfdev, @.***> wrote:
Otherwise you can also use "Dark dimmed" github theme
— Reply to this email directly, view it on GitHub https://github.com/donnemartin/system-design-primer/issues/630#issuecomment-1005271673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJYGZC4TMCDNRK4EFK3CYMTUUOEYBANCNFSM5KTC63YQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
Maybe we can add a grey background instead of the white?
On Sun, 16 Jan 2022, 4:55 am Harsh Batheja, @.***> wrote:
It doesn't quite work for me, it's not dark enough and the text then too looks quite bad on it.
On Wed, 5 Jan 2022, 5:47 am vfdev, @.***> wrote:
Otherwise you can also use "Dark dimmed" github theme
— Reply to this email directly, view it on GitHub https://github.com/donnemartin/system-design-primer/issues/630#issuecomment-1005271673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJYGZC4TMCDNRK4EFK3CYMTUUOEYBANCNFSM5KTC63YQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
it still doesn't work for me. Adding light color to arrows and text outside the boxes would be great. No need to add white/grey all over the background..
Just for reference, it looks like the following issues could be tracked here: #495, #515, #525, #668, #780
When using Dark Mode, all the image text disappears.
Example: