search

donnemartin / system-design-primer

Learn how to design large-scale systems. Prep for the system design interview. Includes Anki flashcards.
Other
268.83k stars 45.44k forks source link

Github Night Theme Makes Images With Transparent Background Illegible #780

Open ghost opened 1 year ago

ghost commented 1 year ago

Hi there, I was just checking out this repository for the first time and noticed your flow chart of system architecture has arrows that end up being hidden if you're viewing github using "night theme".

image

ghost commented 1 year ago

I have little image editing experience - but I create a pull request with the image updated from transparent to white background here: https://github.com/donnemartin/system-design-primer/pull/781

ghost commented 1 year ago

Also - oddly enough - I've never used Anki (the application) before - but when I grabbed the "System Design.apkg" - it has the same problem

Note you can't see any text in the first card:

image

Mouse click and drag reveals text:

image
ghost commented 1 year ago

If anyone else finds this git issue with the same problem - there is a work-around.

If you give focus to the main Anki application window, then select Anki -> Preferences -> Theme

you can override Anki from using the system default and set the theme to Light

lodenrogue commented 1 year ago

Can we add a white outline to the lines, arrows, and components? Should solve the problem.