search

donniebreve / touchcursor-linux

TouchCursor style keyboard remapping for Linux.
GNU General Public License v2.0
133 stars 28 forks source link

Report error for invalid sections and all lines in the section #64

Closed auouymous closed 1 year ago

auouymous commented 1 year ago

Mistyped section names are currently ignored, causing lines from the section to be placed in the previous section. This can silently overwrite the hyper key with another key binding, or worse, it can place all Bindings in the Remap section.

auouymous commented 1 year ago

I just noticed that ',-./;[\] are valid key names. I know that allowing = would cause issues parsing the "key=key" format, but why was ` excluded?

[ is going to cause issues with this patch when [=... is encountered as a binding. I don't think any symbols should be allowed since they all can't be added, and missing symbols would confuse users when some work and others don't.

donniebreve commented 1 year ago

` wasn't excluded, just not included. I don't really like the single character key identifiers either, but I took the PR as it was. I'll probably remove the single character key identifiers in the future.