search

donniebreve / touchcursor-linux

TouchCursor style keyboard remapping for Linux.
GNU General Public License v2.0
133 stars 28 forks source link

Fix Makefile compilation #65

Closed anakojm closed 1 year ago

donniebreve commented 1 year ago

Nice catch :+1:

auouymous commented 1 year ago

The binary should be linked with an $(ldflags) variable, not $(cflags). Then -pthread can be moved from cflags to ldflags.

donniebreve commented 1 year ago

Thanks for the input. It's changed in https://github.com/donniebreve/touchcursor-linux/commit/a466e5533c027d50c2223637aeec4f85aad4932e.

auouymous commented 1 year ago

cflags shouldn't be passed when linking the binary.

-        $(cc) $(objects) $(cflags) $(ldflags) -o $@
+        $(cc) $(objects) $(ldflags) -o $@
donniebreve commented 1 year ago

Changed in https://github.com/donniebreve/touchcursor-linux/commit/106b0105c195861f936abf0510ac381cb5658743.

It's a little hard to find these comments on closed PRs. I would appreciate if you opened an issue and referenced the PR in question.