search

donny681 / ESP32_CAMERA_QR

Apache License 2.0
628 stars 226 forks source link

porting to idf 4.1 dev. #32

Open jjsch-dev opened 4 years ago

Tobias-KW commented 4 years ago

I tested it with my environment: Works like charm with 4.1-dev, even with my camera setup ESP32/OV2640 (M5Stack). Please don't forget to mention that you need to add the esp-camera library, else buidling will fail.

jjsch-dev commented 4 years ago

@Tobias-KW thanks for testing with OV2640, I will add your suggestion in the readme.

s-hemer commented 4 years ago

Thumbs up for this fixes, but as @Tobias-KW already said highlight the use of https://github.com/espressif/esp32-camera or even better add it as submodule (as it was in the "origin" @igrr esp32-cam-demo, same for quirc but that is another story).

jjsch-dev commented 4 years ago

@s-hemer thanks for trying, now I added the instructions to include the library in the IDF components folder.

s-hemer commented 4 years ago

Where did you actually do that, can see it, at least not as part of this pull request. Also, I just realized that you removed the AP mode config stuff. Maybe it is a bad idea to summarize those changes under the topic of porting to idf 4.1 ?!

jjsch-dev commented 4 years ago

@s-hemer, sorry, I made the change to the Readme camera_demo file. Now I also did it in the Readme file of the QR demo. Is the AP mode config stuff the color TEST_PATTERN?

s-hemer commented 4 years ago

The AP mode (or it was STA mode originally) is that the ESP acts as a access point and clients connect directly instead of the ESP connecting to an exisitng wifi or ethernet. Important would be to a) separate this change from the checkin with the changes for idf 4.1 and b) leave this option (add menuconfig for this maybe). Furthermore, a full idf4.1 port would also need a project structure update (i.e. CMakeLists.txt to be able to use idf.py build). And a note in the readme is nice but as I wrote git submodule definition would be the more accurate way.

jjsch-dev commented 4 years ago

@s-hemer thanks for the explanation. I didn't find the AP support in the original @donny681 code, can you show me the related modules and settings?