search

donotturnoff / aerend

My third year project
0 stars 0 forks source link

Use Rule of Three/Five correctly #1

Closed donotturnoff closed 3 years ago

donotturnoff commented 3 years ago

There are a number of classes which have custom destructors, and as a rule of thumb it is a good idea to provide custom copy constructors and copy assignments for them, and in C++11 this is extended to move constructors and move assignments too (see Rule of Three). This is currently not the case, so their necessity should be investigated.

donotturnoff commented 3 years ago

40 addresses an issue I encountered with std::vector<DRMConn> and std::vector<std::unique_ptr<DRMConn>>.