donovan6000 / M33-Fio

The ultimate OctoPrint plugin
GNU General Public License v3.0
125 stars 38 forks source link

Compatibility with TouchUI #161

Open jbliesener opened 8 years ago

jbliesener commented 8 years ago

It would be nice to see M3D-Fio working with the TouchUI plugin. I'm using an Adafruit PiTFT touch panel (3,5", 480x320). I tried to use TouchUI before, but without any success. The latest configuration of Chrome 50 and TouchUI works much better, but M3D-Fio still presents some issues.

Some of the problems I was able to detect on my desktop:

I hope that these errors are relatively easy to correct, as I believe being able to control M3D-Fio through a touchscreen would be a very unique feature. screenshot8 screenshot9 screenshot10

donovan6000 commented 8 years ago

Unfortunately this isn't something that can easily be fixed by changing M3D Fio's code. M3D Fio and TouchUI are both overriding OctoPrint's CSS to accomplish changing the GUI. OctoPrint generates a single CSS file that consists of all the plugin's CSS files, and it parses the plugin's names in alphabetical order so TouchUI's style rules are applied after M3D Fio's. M3D Fio uses the !important property in a lot of style rules in order to prevent OctoPrint and other plugins from overriding them, but those rules can still be overridden by rules applied later that also use the !important property which is what TouchUI also does. So TouchUI is overriding the style rules that M3D Fio relies on for its GUI changes to be displayed properly.