1.22 - Githubissues

donovan6000 / M33-Fio

The ultimate OctoPrint plugin

GNU General Public License v3.0

125 stars 38 forks source link

1.22 #258

Closed jneilliii closed 2 years ago

jneilliii commented 4 years ago

replace deprecated payloads in on_event callback
remove announcement channel being enabled by default

donovan6000 commented 4 years ago

Will the changes you made to replace the deprecated payloads break compatibility with older version's of OctoPrint? If so, can you change it so that it will work with both newer and older version's of OctoPrint?

Everything else looks good. Thank you.

jneilliii commented 4 years ago

It's possible maybe by putting it in a try/catch block, but honestly the property has been deprecated since version 1.3.0, so not sure if it's worth the effort. I think the majority of the users that I've seen complaining about this have been using the latest version of 1.3.x line anyway.