donovan6000 / M33-Fio

The ultimate OctoPrint plugin
GNU General Public License v3.0
125 stars 38 forks source link

Shared library fails with an exception #98

Closed abbradar closed 8 years ago

abbradar commented 8 years ago

For this G-Code generated with Slic3r: https://abbradar.net/me/share/untitled_M3D.gcode

Shared library terminates with an exception, crashing whole OctoPrint along with it.

abbradar commented 8 years ago

I try now to run the same code with the shared library disabled; it takes veeeery long time (4th generation mobile Core i7). Let's see how it goes...

donovan6000 commented 8 years ago

It's fixed in the devel branch now. I've only ever seen the fan speed command, M106, use an S parameter to specify the speed, but your G-code is using a P parameter to do that.

abbradar commented 8 years ago

From this it seems that P sets what fan to use, not its speed. This command looks malformed because the speed is not specified; maybe just ignore them? I'll try to understand why Slic3r generates them.

donovan6000 commented 8 years ago

The G-code file's settings have the fan speed at 100%, so maybe whatever printer type Slic3r is set to use expects P instead of S.

; max_fan_speed = 100
; min_fan_speed = 100

M3D Fio attempts to detect the fan speed before printing so that it can generate a warning if printing without using the fan. It's doesn't affect anything else and it still lets the print proceed even with no fan speed, so it doesn't really matter much.

abbradar commented 8 years ago

Let's close this, thanks for the fix!