donovanhiland / atom-file-icons

MIT License
10 stars 14 forks source link

Odd icon for Rakefiles #1

Closed Alhadis closed 7 years ago

Alhadis commented 7 years ago

Hey there,

I'm wondering where the choice of icon for Rakefiles came from. Was it sourced from this?

Ruby Rake logo Rakefile icon

If so, that page's description would suggest it's not at all connected with Ruby:

Ruby Rake Software is the creation of an experienced master of software industry Mr. Rake. The software guru holds a double Masters in Engineering and Computer Sciences with certified courses in software from top universities of the world…

The icon in particular even seems like a stock logo, going by a reverse image search.

To the best of my current knowledge, Rake doesn't have a logo.

donovanhiland commented 7 years ago

You're right. Rake doesn't have a logo from what I could find. This package was meant to mirror an icon pack I used in Visual Studio Code (https://github.com/vscode-icons/vscode-icons). That's the icon they use. I'm open for any suggestions.

Alhadis commented 7 years ago

Ah. Guess I should bring this up over there, then.

I'm open for any suggestions.

I'd just stick to Ruby's usual icon, to be honest. There are other filenames used in Ruby which have a similar construction: Gemfile, Buildfile, Berksfile, Guardfile, Jarfile... the list goes on. Wouldn't really make sense for Rakefile to be treated differently.

donovanhiland commented 7 years ago

Makes more sense and looks good. Nice catch.

JimiC commented 7 years ago

@donovanhiland The icon association has been done deliberately, exactly because Rakefile doesn't have a logo and we wanted to differentiate the build script from the rest of the Ruby files.

Alhadis commented 7 years ago

Understood. I had a similar experience with the GN build system. I didn't want to use Atom's generic "todo" icon, so I made an icon up instead.

GN stands for "Generate Ninja", referring to the underlying build engine named Ninja. You can see why I wanted something distinctive. =)