search

donovanhiland / atom-file-icons

MIT License
10 stars 14 forks source link

Default folder and default file icons don't show up when using the One Dark theme #4

Closed ghost closed 7 years ago

ghost commented 7 years ago

System:

Issue: The file icons for the folder and empty file(file without any file extension) do not show up in the tree view pane when using One Dark theme

image

Now the same thing but with Atom Dark theme:

image

Similarly it works with Seti UI as well

image

However the opened/expanded folder icon works:

image

No other custom icons package is installed so I don't feel any other icon package is causing the issue. My best guess is some conflict is happening between what One dark has prescribed as the folder icon and that of atom-file-icons.

Side Note: The 1 depreciation you see in the bottom right, is a reference to the atom-editor background-color which I set as black, not related to the file icon issue itself.

donovanhiland commented 7 years ago

This should be fixed in 57d66aa5b539df79a2025a8a523dbe7cf3477801.

donovanhiland commented 7 years ago

Let me know if you come across anything else related to the theme.

ghost commented 7 years ago

Hi, it works now, however the positioning is slightly off

image

If you observe the top left corner, the closed folder icon is slightly raised above the proper position

image

Same thing for the empty file icon in the list tree view. It's not really an issue I guess but other than that everything is working perfectly, just need to adjust the positioning.

And once again its only with this theme, in Atom Dark/Light theme it works without a hitch, position is perfect.