donovanmuller / spring-cloud-deployer-openshift

A Spring Cloud Deployer SPI implementation for OpenShift 3
http://blog.switchbit.io/spring-cloud-deployer-openshift
Apache License 2.0
4 stars 10 forks source link

Service names can only be a maximum of 24 characters long #30

Open donovanmuller opened 7 years ago

donovanmuller commented 7 years ago

This seems to only apply to Services. Therefore you can end up with:

io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: POST at: https://kubernetes.default.svc/api/v1/namespaces/scdf/services. Message: Service "ticktock-timezone-timezone-0" is invalid: metadata.name: Invalid value: "ticktock-timezone-timezone-0": must be no more than 24 characters. Received status: Status(apiVersion=v1, code=422, ...

Need to investigate a good way of handling this. Perhaps truncate?

donovanmuller commented 7 years ago

A warning message might be more useful. Truncating Service names can lead to unexpected behaviour for users.