search

donovanmuller / spring-cloud-deployer-openshift

A Spring Cloud Deployer SPI implementation for OpenShift 3
http://blog.switchbit.io/spring-cloud-deployer-openshift
Apache License 2.0
4 stars 10 forks source link

Namespace of Image is now configurable for ImageStream Trigger #33

Closed retosbb closed 7 years ago

retosbb commented 7 years ago

Hello Donovan,

In our Case the Image of the Deployment is not in the Same Project in Openshift. Therefore we must define the Namespace in which the Image can be found.

This is the change, i have added a additional property for the Deployment.

What do you think about this Change?

Regards, Reto Zeller

donovanmuller commented 7 years ago

Thanks for the contribution Reto!

Apologies for the late reply, I was away for a few days.

Ironically, I might have already implemented something very similar to this on my local branch which I haven't pushed upstream yet 😃

Let me know once you're done with your commits and I'll check if there is any overlap between what we've both done (I will consider yours over mine if it is actually the same implementation, that way at least you didn't waste any time...)

retosbb commented 7 years ago

Hi Donovan,

Okay, i have problems with the IntegrationTests wich are run in this Travis CI. The Log in not completely displayed, so i can not find the error, and that made it a bit dificult. Local i can not run the Integration test.

I will make a new branch, only with the production Code changes(no test code changes).

I will inform you when i'm ready.

retosbb commented 7 years ago

This PR will be deleted. The PR is #34. Not ready yet.

retosbb commented 7 years ago

Hi Donovan,

there is something special. When i add a logback.xml to you coder with the loggin-starter package from spring-boot in Maven, the test is sucess. Without that it fails.

Is this is a known behavior? Have you any idea why this happened.

Reto

donovanmuller commented 7 years ago

No idea 😕 I'll take a look and review #34 tomorrow...