search

donovanmuller / spring-cloud-deployer-openshift

A Spring Cloud Deployer SPI implementation for OpenShift 3
http://blog.switchbit.io/spring-cloud-deployer-openshift
Apache License 2.0
4 stars 10 forks source link

Namespace of Image for ImageStreamTrigger is now Configurable #34

Closed retosbb closed 7 years ago

retosbb commented 7 years ago

Hello Donovan,

In our Case the Image of the Deployment is not in the Same Project in Openshift. Therefore we must define the Namespace in which the Image can be found.

This is the change, i have added a additional property for the Deployment.

What do you think about this Change?

Regards, Reto Zeller

retosbb commented 7 years ago

I have seen that my changes are made only for a maven-Resources. But we use a Docker Image as Image, and this is handeled in other Part of Code.

Which I can modify now. Pherhaps it makes now sense, to discard my changes and wait on your changes.

donovanmuller commented 7 years ago

Ok, I'll try my best to push that change later tonight. After that you can determine if it'll satisfy your use case and we can tweak from there.

retosbb commented 7 years ago

This will be a good approach. We dont need that feature very urgently. Restart the Stream manually, when a new version is available is not so painful. But it would be nice, if that would happen automatic.

Thanks for you support.

donovanmuller commented 7 years ago

@retosbb I haven't forgotten 😄 , just struggling to find the time, Will do as soon as I can.

donovanmuller commented 7 years ago

@retosbb Looking at my local branch I actually implemented something quite different for my use case. See dockerRegistryOverride and imageProjectName I'm merging this for now.

This might change though, when I investigate #37