search

donpark / html2jade

Converts HTML to Jade template. Not perfect but useful enough for non-daily conversions.
MIT License
1.18k stars 156 forks source link

Breaks inline SVG's viewBox #119

Open codysherman opened 7 years ago

codysherman commented 7 years ago

Posting this here, apologies if it's already been fixed but it's still live on http://html2jade.aaron-powell.com/ and http://html2jade.org/ at least.

SVGs are being completely broken by the conversion. The attribute capitalization is not being preserved, which will break their functionality. In my case, I just spent the last 4 hours figuring out that "viewBox" got switched to "viewbox". The SVG still appears, but all responsive design resizing is removed.

Here is an example SVG to test (GitHub doesn't allow attached SVGs for some weird reason): `

`

It's very important to the ability to style/scale the inline SVG that the "B" in viewBox remains capitalized.

aichholzer commented 7 years ago

Hello @codysherman -Thank you for bringing this up. I will take a look and come back to you about it.

basaran commented 3 years ago

yes, this is indeed very important. It took me about 5 hours to realize the case sensitivity :)