search

donpark / html2jade

Converts HTML to Jade template. Not perfect but useful enough for non-daily conversions.
MIT License
1.18k stars 156 forks source link

Modifies actual text when it shouldn't while using http://html2jade.aaron-powell.com/ #91

Closed doivosevic closed 9 years ago

doivosevic commented 9 years ago

I have noticed this issue making serious adjusments to my code.

<h2 class="page-title">Tables - <span class="fw-semi-bold">Dynamic</span></h2>

gets turned into

h2.page-title | Tables - <-- span.fw-semi-bold Dynamic

Notice how there is no space after - This seems like a serious issue to me since now I do not know how many actual mistakes have happened

donpark commented 9 years ago

Which version are you using? Reason I ask is because whitespace related bug fix was recently made and version 0.8.1 does retain the whitespace after the dash.

Note that websites providing html2jade services may be using an older version of html2jade.

doivosevic commented 9 years ago

I have noticed that you have just recently made a fix for #76

I was using http://html2jade.aaron-powell.com/ so I'm not sure if the page is not updated or the fix is not complete

donpark commented 9 years ago

I've tested and confirmed that the fix in version 0.8.1 does at least work for your example HTML.

http://html2jade.aaron-powell.com/ is very likely using an older version without the fix.

donpark commented 9 years ago

@aaronpowell could you update http://html2jade.aaron-powell.com/ to use latest version (0.8.1) of html2jade when you get a chance? It has whitespace bug fix which is very common. Thanks.

doivosevic commented 9 years ago

I'm going to install with npm then. Thanks!

doivosevic commented 9 years ago

@aaronpowell could you also display the number of the versioun used on your website? I suppose that will fix all such future problems

aaronpowell commented 9 years ago

I've finally got my hands on a non-Windows machine so I can do the update/testing (html2jade doesn't work on Windows due to JSDom, which is why I made the site).

Also changed the styling a little, it's not quite as ugly :stuck_out_tongue:

donpark commented 9 years ago

site looks good. version and all. :-)