search

donpark / html2jade

Converts HTML to Jade template. Not perfect but useful enough for non-daily conversions.
MIT License
1.18k stars 157 forks source link

fix jsdom-little not compatible with nodejs 0.11.x #94

Closed zxdong262 closed 9 years ago

zxdong262 commented 9 years ago

just replace jsdom-little with jsdom

donpark commented 9 years ago

Zhao, I can appreciate your trying to help but let's not forget the context which is: html2jade is primarily just a file conversion tool. To use it, people can just run it under node 0.10.x. With tools like nvm, it's easy to have multiple versions of node.

Now, html2jade used to use jsdom but there were compatibility and platform issues in later versions, both of which jsdom-little resolved. Going back will mean having to revisit those issues which may be gone by now but still takes time to examine and confirm, time which I can't afford right now. I'll take a look at this later when I can.

So I think there is little reason to support 0.11.x. When node 0.12 is released, I'll revisit this issue.