search

donpark / html2jade

Converts HTML to Jade template. Not perfect but useful enough for non-daily conversions.
MIT License
1.18k stars 156 forks source link

Issue 96 omit commas #97

Closed focusaurus closed 9 years ago

donpark commented 9 years ago

Sorry but I think this feature needs to be optional, meaning via a CLI flag (maybe --noattrcomma), to maintain backward compatibility.

focusaurus commented 9 years ago

OK, I can add that. Not really sure backward compatibility is important for a project like this. How many people are re-running html2jade over and over again on the same inputs? Anyway, I'll add it. Just wanted to mention that I think the commas between attributes were due to some limitations in jade TJ couldn't get around in early versions that have long since been solved and they always seemed like a huge wart to me, so I was very pleased when jade finally made them optional.

On Thu, Feb 12, 2015 at 9:11 PM, Don Park notifications@github.com wrote:

Sorry but I think this feature needs to be optional, meaning via a CLI flag (maybe --noattrcomma), to maintain backward compatibility.

— Reply to this email directly or view it on GitHub https://github.com/donpark/html2jade/pull/97#issuecomment-74202681.

donpark commented 9 years ago

I went ahead and implemented the changes needed and released it as version 0.8.3 so I'll this close this PR but I do appreciate your help on this @focusaurus. Thanks. :-)

donpark commented 9 years ago

Re unnecessary commas, yeah. TJ was experimenting a bit. Not entirely happy with the result but it serves my needs. Re backward compatibility, I see your point since this is just a tool but what I wanted to avoid breaking anything if possible.