Closed dnextreme88 closed 9 months ago
Hey there, thanks for submitting a PR. Could you share a screenshot / video of the changes you did in action? It will help me to better review the changes overall.
Hey! Apologies for the abrupt PR. Found a layout bug for XL viewport. Kindly see attached for the changes. Thank you!
Original:
Changed:
No worries at all, I have my email notifications on still, so I get to follow up fairly quickly.
Thanks for the addition. Looks good to me, so I'll integrate this as is. This particular version has a manual deployment so it won't be immediately up, but I'll post a comment when it is done.
Hey @dons20, I don't think this was deployed yet, last deployment mentioned 5 years ago. I just stumbled upon this review editor again and was using it for a review I would be submitting but realized the changes weren't reflected yet.
@dnextreme88 Should be visible now, I don't recall what deploy process I had in place at that time, but for now I just synced the changes with my gh-pages branch and it deployed automatically.