dontLoveBugs / SupervisedDepthPrediction

Pytorch framework for supervised depth prediction
40 stars 15 forks source link

Potential bug in loss calculation? #5

Closed ackbar03 closed 4 years ago

ackbar03 commented 4 years ago

Hi,

I think you have a bug in this line

https://github.com/dontLoveBugs/SupervisedDepthPrediction/blob/b293ed8dbfadba7f841ff96bb55c141b26512d28/dp/modules/losses/ordinal_regression_loss.py#L61

entropy = -prob * ord_label

There doesn't seem to be any reason for prob to be multiplied by -1. I also see from your commit history that it seems to be correct before, is this possibly a typo?

ackbar03 commented 4 years ago

nvm I'm an idiot