donthedeveloper / site-builder

GNU General Public License v3.0

6 stars 10 forks source link

104-Added /auth/forgot/ tests #110

Closed JPM1118 closed 5 years ago

JPM1118 commented 5 years ago

104

REQUIRES #84 to be merged

Tested for 200 status on non-existent user.
Tested for 200 on existent user.
Tested for token and token expiration creation for the user.

donthedeveloper commented 5 years ago

Check out these 2 PRs. Ben (mentor) left some fantastic feedback for Ben (other Ben) on writing and organizing tests.

https://github.com/donthedeveloper/site-builder/pull/83 https://github.com/donthedeveloper/site-builder/pull/80

Definitely check out his comments on how to organize these tests within describe blocks. If you have any specific questions, feel free to DM me.

JPM1118 commented 5 years ago

I read the comments from Ben's test PR's and I made some small changes, but I am still not entirely sure if I am writing these tests corrects. Hopefully, you can give me some feedback.

Also, should I be testing if node mailer sent a email successfully. If so, I not entirely sure how. Any pointers would be much appreciated. Thanks!