windows: Do not explicitly link ntdll.dll and msvcrt.dll

dontpanic92 / wxGo

Golang wxWidgets Wrapper

Other

404 stars 51 forks source link

windows: Do not explicitly link ntdll.dll and msvcrt.dll #49

Closed k-takata closed 6 years ago

k-takata commented 6 years ago

Linking ntdll.dll has unexpected side effects. See: https://github.com/golang/go/issues/12030

Starting from Go 1.8, it is not necessary to link ntdll.dll and msvcrt.dll explicitly. Link them explicitly only for < 1.8. See: https://golang.org/cl/30737

dontpanic92 commented 6 years ago

It seems that explictly linking to msvcrt.dll doesn't cause problems according to the issue and the PR, but it is unnecessary.

ntdll.dll definitely shouldn't be explictly linked.

dontpanic92 commented 6 years ago

Many thanks for your work!