donum / curvycorners

Automatically exported from code.google.com/p/curvycorners
0 stars 0 forks source link

Buggy browser detection (use feature detection!) #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Running a Firefox nightly build, I get an alert 'Scanstyles does nothing in
Webkit/Firefox'. This is because Firefox nightlies are branded 'Minefield',
so your isMoz check fails.

This will also trigger the message on anything that isn't IE, Firefox,
Opera or Webkit.

You should probably borrow the 'does this browser support border-radius'
feature check from modernizr and use that instead.

Original issue reported on code.google.com by dougdoug...@googlemail.com on 11 Oct 2009 at 3:06

GoogleCodeExporter commented 9 years ago
Mozilla detection now improved by adding a check for Mozilla-specific style 
name. 
(Actually there is a valid distinction between feature detection and browser 
detection, but thanks for the mention of modernizr, which is a useful tool.)

Original comment by c.1%smit...@gtempaccount.com on 14 Oct 2009 at 11:34