search

donum / curvycorners

Automatically exported from code.google.com/p/curvycorners
0 stars 0 forks source link

Browser detection still failing for some versions of Firefox #72

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Even though this is supposedly fixed already, I'm still getting the
"Scanstyles does nothing in Webkit/Firefox/Opera" alert dialog on Firefox
3.6.4pre under Linux (named Namoroka).

After some googling around, it seems the isMoz variable should be set by
looking for "gecko" instead of "firefox" in the user agent string to ensure
correct detection of all Firefox versions. Maybe this is a possible fix for
this issue.

I'm using the latest CC 2.1 beta.

Original issue reported on code.google.com by eduoj...@gmail.com on 10 Apr 2010 at 7:20

GoogleCodeExporter commented 9 years ago 
Believed fixed in r170. Please verify.

Original comment by c.1%smit...@gtempaccount.com on 11 Apr 2010 at 2:54

GoogleCodeExporter commented 9 years ago 
Hi,
Using the latest Firefox (Minefield/4.0b3pre) this issue still isn't resolved 
since the script still seems to be looking for "Firefox" and not "Gecko".

Looking at the trunk, I see the curvycorners.src.js contains the following test:
if (!(this.isMoz = agent.indexOf('firefox') !== -1)) { 

I see that at some point in the past it also checked for gecko (r127):
this.isMoz     = agent.indexOf('firefox') !== -1 || agent.indexOf('gecko') !== 
-1;

Is there a reason it was changed back at some point?

Original comment by smoo...@gmail.com on 22 Jul 2010 at 7:41

GoogleCodeExporter commented 9 years ago 
Oops sorry, I did not see the extra tests you do in the case of 
!(this.isMoz...).
I tried the curvycorners.net (which fails) and hadn't realized it's not using 
the trunk version...

Also, I don't have a website to test the trunk version with the latest Firefox 
so I can't verify this works with the latest Firefox...

Original comment by smoo...@gmail.com on 22 Jul 2010 at 9:34

GoogleCodeExporter commented 9 years ago 
For non-Firefox branded firefoxes, if the first element on the page with a 
style has a style member MozBorderRadius then in post-r170 versions we 
nevertheless diagnose the browser as Firefox. This will stop working when 
Firefox stops supporting MozBorderRadius.

Original comment by c.1%smit...@gtempaccount.com on 22 Jul 2010 at 9:52