donum / curvycorners

Automatically exported from code.google.com/p/curvycorners
0 stars 0 forks source link

making curvycordners non-conflicting and js-lint correct for minification #83

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. include curvycorner twice with different versions (as that may happen on CMS 
systems like joomla when template and a component both use their own 
curvycorners.src.js
2. minify curvycorners with google's tool: won't compile
3.

What is the expected output? What do you see instead?
1. javascript error
2. compilation error.

What version of the product are you using? On what operating system?
latest SVN of today ( r172 )

Please provide any additional information below.

Please see fixed file attached (added a closure, so all name-space is local 
instead of global) and also quite a few missing semi-columns ;

It would be great if you would accept this small contribution into trunk.

Best Regards,
Beat

Original issue reported on code.google.com by beat...@gmail.com on 2 Jul 2010 at 11:31

Attachments:

GoogleCodeExporter commented 9 years ago
oops sorry for mistypo in title, can't edit it

Original comment by beat...@gmail.com on 2 Jul 2010 at 11:32

GoogleCodeExporter commented 9 years ago
Brilliant.  I looked at doing the same thing to reduce the file size but got 
fed up after a while!

Original comment by p...@lisvane.me.uk on 29 Aug 2010 at 4:03

GoogleCodeExporter commented 9 years ago
We will certainly look to incorporate this into the trunk soon.

Original comment by c.1%smit...@gtempaccount.com on 24 Sep 2010 at 11:27