donydchen / ganimation_replicate

An Out-of-the-Box Replication of GANimation using PyTorch, pretrained weights are available!
MIT License
247 stars 48 forks source link

生成器输出内容公式 #28

Open Caesar-T opened 1 year ago

Caesar-T commented 1 year ago

你好,请问为什么代码中的公式与论文中的公式是不同的? 代码中公式:self.fake_img = self.aus_mask self.src_img + (1 - self.aus_mask) self.color_mask 论文中公式:self.fake_img = self.aus_mask self.color_mask + (1 - self.aus_mask) self.src_img

donydchen commented 1 year ago

Hi @Caesar-T , thanks for your interest in this project.

I am not the author of the paper, but I also discovered years ago that the mask combination implementation in the official project differs from the paper. In short, even if the two terms are swapped, I recall that it should still work out.

For more details, please refer to the previous discussions at https://github.com/albertpumarola/GANimation/issues/21 and https://github.com/donydchen/ganimation_replicate/issues/6#issuecomment-493880864. Hope it helps.

Caesar-T commented 1 year ago

@donydchen Thank you very much, your reply was very helpful