search

donysukardi / jest-img-snapshot

Jest matcher for image comparisons using pixelmatch with all the goodness of Jest snapshots out of the box.
MIT License
1 stars 0 forks source link

Possible merge with jest-image-snapshot? #1

Open anescobar1991 opened 6 years ago

anescobar1991 commented 6 years ago

Hi there!

Is there any reason to not implement some of these changes on top of jest-image-snapshot? I am the maintainer for that project and I would have loved to see these changes be added in there as most of the issues this package solves are already being tracked and so it could have been nice to close them in there as opposed to creating a new package!

donysukardi commented 6 years ago

Hi Andres! Thanks for reaching out.

I'm aware of the issues filed on https://github.com/americanexpress/jest-image-snapshot/issues. The only reason why I didn't do a pull request is that I reckon that it was going to be a big breaking change if I try to incorporate my approach to jest-image-snapshot and I'm afraid I don't have a lot of time and resources to do that. Hence, it was easier for me to start from scratch.

But sure, I would love to see these changes getting incorporated into jest-image-snapshot. How do you propose we do it? Perhaps we can do a major release.

anescobar1991 commented 6 years ago

I guess firstly we should identify what the missing features are. From a quick look at your README I see that cleaning up unused snapshots and updating of only failing snapshots are things we'd like to port over. The interactive mode updating actually works now as of v2.4.3.

Are those all the features? If not let's get the others documented as issues in jest-image-snapshot and create a roadmap for the next release. As for requiring a major version what breaking changes are you seeing? From looking at the README I don't see any API differences between this matcher and jest-image-snapshot.