dooboolab-community / flutter_inapp_purchase

(Sun Rised!) Flutter plugin for In App Purchase.
MIT License
549 stars 235 forks source link

Update to support Flutter 3 #395

Closed giolaq closed 12 months ago

giolaq commented 1 year ago

Is there any plan to update the plugin to Flutter 3?

eEQK commented 1 year ago

is there anything that stops you from using this plugin with flutter 3?

giolaq commented 1 year ago

Not really, the plugin is working with Flutter 3. Maybe we could update the sample app to Flutter 3?

temelyazilim commented 1 year ago

FlutterInappPurchase.instance.getProducts doesn't work after flutter 3.7.7 update.

meowofficial commented 1 year ago

@temelyazilim In my case the issue arised after setting base country for upcoming Apple price change. Previously working TestFlight build stopped work, but the same build in production works as expected. Similar issue by developer not using this plugin https://community.revenuecat.com/general-questions-7/i-can-t-get-iap-only-subscriptions-2667.

temelyazilim commented 1 year ago

ios working but android doesn't show prices.

temelyazilim commented 1 year ago

@temelyazilim In my case the issue arised after setting base country for upcoming Apple price change. Previously working TestFlight build stopped work, but the same build in production works as expected. Similar issue by developer not using this plugin https://community.revenuecat.com/general-questions-7/i-can-t-get-iap-only-subscriptions-2667.

flutter 3.7.7 FlutterInappPurchase.instance.getProducts results;

not working - android

android

working - ios

ios
meowofficial commented 1 year ago

@temelyazilim Looks like a different issue comparing to mine. Instead of non-consumable products I get an empty list. I don't have consumable products. You could try to downgrade the flutter_inapp_purchase version, last version brought some changes to android billing.

temelyazilim commented 1 year ago

yes, we are using 5.4.0

Karol @.***>, 13 Mar 2023 Pzt, 13:10 tarihinde şunu yazdı:

@temelyazilim https://github.com/temelyazilim could it be related to google releasing play billing 5.1 library? are you running the latest version (5.4.0) of flutter_inapp_purchase?

— Reply to this email directly, view it on GitHub https://github.com/dooboolab/flutter_inapp_purchase/issues/395#issuecomment-1465854627, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARQ3JO6APB6TY2BJ3O422WDW33XA3ANCNFSM6AAAAAAUUAY4EU . You are receiving this because you were mentioned.Message ID: @.***>

temelyazilim commented 1 year ago

we downgrade to flutter_inapp_purchase: 5.2.0

now working again. what should we do to use 5.4.0? ios working but android not.

renolation commented 1 year ago

im using 5.2.0 and the price now show in android

hyochan commented 1 year ago

@renolation @temelyazilim The major changes in 5.4.0 in android is that billing client is upgraded to 5.1. This is done in #392 by @SamBergeron.

If possible could @SamBergeron join this conversation?

renolation commented 1 year ago

@renolation @temelyazilim The major changes in 5.4.0 in android is that billing client is upgraded to 5.1. This is done in #392 by @SamBergeron.

If possible could @SamBergeron join this conversation?

in android 13 and plugin 5.4.0 i got this Please fetch setObfuscatedAccountIdproducts first by calling getItems. but when i get items, it gets enough but the price is null

offline-first commented 1 year ago

Here is a fix for the one time purchases (price is null) here is my pr: https://github.com/dooboolab-community/flutter_inapp_purchase/pull/435

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 90 days with no activity. Leave a comment or this will be closed in 7 days.