search

dooboolab-community / flutter_inapp_purchase

(Sun Rised!) Flutter plugin for In App Purchase.
MIT License
549 stars 235 forks source link

Fix #418. #423

Closed deakjahn closed 1 year ago

deakjahn commented 1 year ago

Discussion at #418.

codecov[bot] commented 1 year ago

Codecov Report

Merging #423 (e389110) into main (33b69ea) will increase coverage by 0.10%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   47.69%   47.79%   +0.10%     
==========================================
  Files           4        4              
  Lines         478      477       -1     
==========================================
  Hits          228      228              
+ Misses        250      249       -1
Impacted Files Coverage Δ
lib/modules.dart 47.22% <ø> (+0.26%) :arrow_up:
deakjahn commented 1 year ago

Also: "By the way, small error, toString() of IAPItem has an error, it displays two items with the label introductoryPricePaymentModeIOS, the first one is superfluous, it's a repeated display of introductoryPrice."

deakjahn commented 1 year ago

@hyochan That's not so simple, it was either-or, this PR was about the same error. If you merged the other, there's no need for this one.

Almost. There's still the single extraneous line in modules.dart that you could easily remove manually. It's an obvious duplicate line.