dooboolab-community / flutter_inapp_purchase

(Sun Rised!) Flutter plugin for In App Purchase.
MIT License
549 stars 236 forks source link

fix: Support AGP8 namespace #467

Closed dev-yakuza closed 8 months ago

dev-yakuza commented 8 months ago

First, thanks for the great package.

Now, Flutter supports AGP8, so I try to use it.

But, I got the following error.

Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.
ain

And, I realize flutter_inapp_purchase doesn't support the namespace.

This PR is not perfect to support the AGP8, but it can fix the namespace issue simply.

Reference

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a94c705) 47.24% compared to head (649725d) 47.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #467 +/- ## ======================================= Coverage 47.24% 47.24% ======================================= Files 3 3 Lines 472 472 ======================================= Hits 223 223 Misses 249 249 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dev-yakuza commented 8 months ago

@hyochan I understand you are very busy,but could you check this PR? 🙏

dev-yakuza commented 8 months ago

Before merging the PR, I decide to use the following way.

-  flutter_inapp_purchase: ^5.6.0
+  flutter_inapp_purchase:
+    git:
+      url: https://github.com/dev-yakuza/flutter_inapp_purchase.git
+      ref: fix-agp8