Closed Shaw-Signaturize closed 7 months ago
@usmanabid94 Sorry I think there might be a misunderstanding. The article linked only showed a basic setup of IAP.
The issue relates specifically to the introductory offers returning in the JS. In store kit 1 this all returns correctly and is mapped to the JS correctly. In store kit 2 the native object also gets the information but is never mapped to the JS. All my proposed modification does is add the properties to the mapping function in line with the current typescript.
My main query here is one of clarification from the maintainers as the two IOS implementations for introductory offers have quite a significant interface difference.
same here. where is subscriptionSk2Map ? how to fix it ?
subscriptionSk2Map
I ended up forking the repo and making a package override as i heard nothing from the maintainers on the issue.
If you clone the repo and search for subscriptionSk2Map
you should find the function definition. Replace with what I pasted above and it should start working.
As a word of caution i forked from 12.10.5 and there seems to be a few more patches since then.
subscriptionSk2Map
I ended up forking the repo and making a package override as i heard nothing from the maintainers on the issue. If you clone the repo and search for
subscriptionSk2Map
you should find the function definition. Replace with what I pasted above and it should start working.As a word of caution i forked from 12.10.5 and there seems to be a few more patches since then.
I tried to add this and check It works on the debug mode, but when tried to push the app on TestFlight to test... the free trial details doesn't show up on the pop up.
Any idea on this? @Shaw-Signaturize @andresesfm
subscriptionSk2Map
I ended up forking the repo and making a package override as i heard nothing from the maintainers on the issue. If you clone the repo and search for
subscriptionSk2Map
you should find the function definition. Replace with what I pasted above and it should start working. As a word of caution i forked from 12.10.5 and there seems to be a few more patches since then.I tried to add this and check It works on the debug mode, but when tried to push the app on TestFlight to test... the free trial details doesn't show up on the pop up.
Any idea on this? @Shaw-Signaturize @andresesfm
I had a similar issue as our build process runs the npm install and pod install before bundling to testflight. My best guess would be to check your node_modules and check that the version being used is your custom version and it hasnt pulled the one off the public npm.
I think as this problem seems to be hitting a few people I will try and get the change bundled into a PR and get feedback that way
@Shaw-Signaturize Sure, that would really help Since it's the most high priority use case that anyone would want to get it implemented and working.
Looking forward to your PR
@Shaw-Signaturize Sure, that would really help Since it's the most high priority use case that anyone would want to get it implemented and working.
Looking forward to your PR
Cool ill see if i can get to it early next week
@Shaw-Signaturize Were you able to create PR for this ?
@Shaw-Signaturize any update on this ? Looking forward to this PR
@RashVenkat6795 Sorry about the delay. Thought i was going to have availability that week and then other things got in the way. PR should be up now
PR: https://github.com/dooboolab-community/react-native-iap/pull/2630
@Shaw-Signaturize thanks for this PR Also I have one more question.... I submitted my first version of app... was able to see the introductory offer with trial periods as configured properly, now when i'm trying to submit the next version of app with some loaded features... but with this new version, I'm not able to see the free trial details in payment sheet.
Any possible issues you can think of ?
Description
When using Ios Storekit1 for retrieving subscriptions, information on the associated introductory offers populates onto the properties
This however does not seem to be the case when using Storekit2 and the properties do not seem to be exposed on any other interface
Expected Behavior
If backwards compatibility is being maintained the properties should populate with the same information
Environment:
To Reproduce Steps to reproduce the behavior:
[Optional] Additional Context
After debugging it would appear that the issue seems to stem from the function
subscriptionSk2Map
as it is missing property mapping for the introductory properties.Suggested change would be the following if it is to maintain backwards compatibility with
SubscriptionIOS
typeIm happy to create a PR for this but looking to confirm the intent in terms of structure if it is remaining backwards compatible or if it is to follow more closely with the new IOS structure