search

dooboolab-community / react-native-iap

In App Purchase module for React Native!
https://react-native-iap.dooboolab.com
MIT License
2.73k stars 629 forks source link

fix: Send purchase-updated instead of purchase-update. #2739

Closed dwyery closed 1 month ago

dwyery commented 1 month ago

During some testing of restoring purchases using the getAvailablePurchases method with the alsoPublishToEventListener argument set to true I noticed that the events were not being published correctly. I also noticed in the logs an error message saying that purchase-update was not a supported event.

I had a look at the code in RNIapIosSk2.swift and it appears that the event name should actually be purchase-updated.

I fixed this locally and the error no longer appears and the purchase is now being published to the event listener.

Creating this as a draft PR as I am not too sure if there is anything else I need to do, this is my first contribution to the project.

dwyery commented 1 month ago

Looks like the build is failing with:

Run swiftlint lint --fix --format --path ios/*.swift --config .swiftlint.yml

/Users/runner/work/_temp/cc0d47bb-9bc0-431a-bb28-0434ffd4767d.sh: line 1: swiftlint: command not found

Is there something I am missing?

hyochan commented 1 month ago

Looks like the build is failing with:

Run swiftlint lint --fix --format --path ios/*.swift --config .swiftlint.yml

/Users/runner/work/_temp/cc0d47bb-9bc0-431a-bb28-0434ffd4767d.sh: line 1: swiftlint: command not found

Is there something I am missing?

It is weird that swiftlint isn't preinstalled in recent macos image. I've added brew install swiftlint step.