search

doodlewind / nativebird

🐦 Bluebird alternative within ~200 loc
78 stars 8 forks source link

feat: add `Promise.asCallback` #13

Closed talentlessguy closed 4 months ago

talentlessguy commented 4 months ago

Tests are ported from https://github.com/petkaantonov/bluebird/blob/3817d50b9d6aa6ca949073939f428925bd8aae2d/test/mocha/nodeify.js#L70

talentlessguy commented 4 months ago

tbh I'm not sure now if we should add it since there's util.callbackify, but on the other side asCallback would be runtime-agnostic

doodlewind commented 4 months ago

Looks fine to land, thanks for the feat!