Closed saluzafa closed 10 months ago
Also, I'm not sure if they've changed their licensing, but as far as I know, only tokens made by Ross McConnell from 2-Minute Tabletop may be used in Dungeon Club. The ones you've added are made by David Wilson and unfortunately might have to be replaced.
When I first contacted 2-Minute Tabletop back in November 2021, that's what they told me:
Just make sure you only use tokens made by Ross, and not tokens made by our other token artists, as those are not covered by the same licensing. The ones you have are good though, as that's all Ross's work!
Tokens by HammertheShark and David are intended for personal use only. [...] The 'safe to use' tokens are here: https://tools.2minutetabletop.com/token-editor/index?author=rossmcconnell
Hello @doodlezucc !
Thanks a lot for all your time and reviews, very happy to get a feedback from you 😄 . I'm sorry for all the code mistakes, it was my first time playing with Dart, it's a very nice language 😎 .
I took care of all the reviews you made, I hope I didn't miss something let me know if it's the case 😄 . I also deleted all tokens made by David Wilson and downloaded all tokens from Ross McConnell ! 🎉
Can you test the ping effect please? Not sure if the animation is good or not (I'm a very bad UX designer).
Cheers!
Wow, you're extremely fast! :D
Thanks! :D
I'll take a look at the styling of pinged tokens tomorrow. Apart from that, this PR looks good to me and is considered practically approved. Thanks so much for your contributions and for implementing the previous requested changes!
Your welcome :)
Actually, because I'm trying to move away from the term "movable", you could instead write tokens_per_scene here and update the getter name accordingly.
movables_per_scene
to tokens_per_scene
;movablesPerScene
to tokensPerScene
.Cheers!
Hi @saluzafa, the ping animation looks fine to me! Thanks for your work :)
Changelog
[feature] allow MacOS shortcuts on board (
Cmd+C
,Cmd+V
, ...) [feature] Entity assets picker [feature] add config fileconfig.yaml
for configuring limits and database directory [feature] allow ping & "go to" for movable objects and sync it with others players [misc] add login.yaml to .gitignoreFeatures
Configuration file
Server now uses a configuration file to define limits & database path constants.
Entity Assets Picker
This allows GM to use special assets for their custom tokens (like players tokens).
Ping & Go To tools for movable objects
Ping tool
When a GM does a ping, it makes the token "heartbeating" for 10 seconds
Go To tool
Allows a GM to focus all players' screen on a specific token.