doodlum / Skyrim-Community-Shaders

SKSE core plugin for community-driven advanced graphics modifications for AE, SE and VR. Also fixes bugs and improves performance.
GNU General Public License v3.0
137 stars 41 forks source link

fix: PBR directional light specular fix and llf compile fixes #415

Closed doodlum closed 1 month ago

doodlum commented 1 month ago

ScreenShot3950 ScreenShot3951

Fixes directional lights applying to the specular in interiors. This doesn't make sense for the specular since we already include ambient light like that in the dynamic cubemap.

Also fixes the light limit fix debug visualisations compile errors, and removes unneeded color clamping.

Pentalimbed commented 1 month ago

Would that break certain interiors that has sunlight? Imo should check if it is shadowed too.

Pentalimbed commented 1 month ago

Title should reflect better what it actually does.

doodlum commented 1 month ago

Would that break certain interiors that has sunlight? Imo should check if it is shadowed too.

It checks for this

doodlum commented 1 month ago

Title should reflect better what it actually does.

There, changed it

FlayaN commented 1 month ago

This is a fix: not a feat:

doodlum commented 1 month ago

I will rename it to fix because the LLF part at least is definitely a fix.

Pentalimbed commented 1 month ago

Would that break certain interiors that has sunlight? Imo should check if it is shadowed too.

It checks for this

Then I think I should have another name since it's not exactly all interior, or at least add a comment listing the exceptions.

doodlum commented 1 month ago

Would that break certain interiors that has sunlight? Imo should check if it is shadowed too.

It checks for this

Then I think I should have another name since it's not exactly all interior, or at least add a comment listing the exceptions.

Where would you like there to be a comment? The definition of "interior" is the same as defined by enbseries.

Pentalimbed commented 1 month ago

Where would you like there to be a comment? The definition of "interior" is the same as defined by enbseries.

In SharedBuffer.hlsli, after the buffer variable definition, for example.

No matter what enb does, people who don't know how enb does things will be confused.

doodlum commented 1 month ago

Would "directional shadows" or similar be a better name?

Pentalimbed commented 1 month ago

Would "directional shadows" or similar be a better name?

Better than before, but don't some foggy weather or moonlight lacks shadow too iirc?

doodlum commented 1 month ago

Would "directional shadows" or similar be a better name?

Better than before, but don't some foggy weather or moonlight lacks shadow too iirc?

They still render shadow maps.

Pentalimbed commented 1 month ago

They still render shadow maps.

Ok, now rename the thing then