search

doodlum / skyrim-community-shaders

Community-driven advanced graphics modifications for AE, SE and VR. Also fixes bugs and improves performance.
GNU General Public License v3.0
187 stars 46 forks source link

build: introduces a windows based build container #524

Closed mnkll closed 2 months ago

mnkll commented 2 months ago

For those preferring to build in containers, based on a windows container. Might do Linux in the future to avoid the cursed windows containers and their size, even when taking core images. This could be the first step towards some form of CI setup.. or stay just another, quicker way to build.

Not perfect, had ideas to reuse the BuildRelease.bat more by putting the user preset check and generation plus directory replacement in there. Or extend it with another parameter and pass the output directory overwrite required for the container directly to cmake (maybe -DCommunityShadersOutputDir=C:\skyrim-community-shaders). CMD limitations make that ugly without extra dependency so it stays in the container specific script for now.

Any suggestions welcome.

alandtse commented 2 months ago

Looks like a build: PR. CI: typically covers actually ci for the project. That said, look like a good idea. We do probably want a ci that confirms PRs build and probably a release ci.

Please also review and approve #513 before we merge this.

mnkll commented 2 months ago

Looks like a build: PR. CI: typically covers actually ci for the project. That said, look like a good idea. We do probably want a ci that confirms PRs build and probably a release ci.

Please also review and approve #513 before we merge this.

Don't have the status to review that I think, OK with me tho.

alandtse commented 2 months ago

Anyone should be able to hit approve. If you can't, just comment saying you approve there.