search

doodlum / skyrim-community-shaders

Community-driven advanced graphics modifications for AE, SE and VR. Also fixes bugs and improves performance.
GNU General Public License v3.0
187 stars 46 forks source link

build: use individual file timestamps for copy_shaders #526

Closed alandtse closed 1 month ago

alandtse commented 2 months ago

@FlayaN can you make sure this looks right to you?

alandtse commented 2 months ago

Issue I ran into is that it complaints of an existing .rule file. Not sure where that comes from.

FlayaN commented 1 month ago

@FlayaN can you make sure this looks right to you?

A weird review but I created a PR with some details here :P https://github.com/alandtse/skyrim-community-shaders/pull/4

Issue I ran into is that it complaints of an existing .rule file. Not sure where that comes from.

Fixed that in my PR, added some details why that happens (short answer is that the subfolder of the auto-deploy folder is not always unique, always ends with /Data and then choosing Data as the name for both of them and causes a duplicate rule file)

alandtse commented 1 month ago

Thanks. It's possible I asked an ai and didn't really think through all changes. . .

alandtse commented 1 month ago

Ok, I just realized the issue is all I'm doing it changing what is copied into the aio directory. There's a whole another issue where it just copies everything from aio to the deploy targets. I was trying to solve filewatcher having to rebuild EVERYTHING. But that's way too much work for me.

I'm going to open an issue and hopefully someone can fix it.

alandtse commented 1 month ago

Basically the issue all boils down to THIS deleting and recreating the directory. COMMAND ${CMAKE_COMMAND} -E copy_directory "${AIO_DIR}/Shaders" "${DEPLOY_TARGET}/Shaders"