search

doodlum / skyrim-community-shaders

Community-driven advanced graphics modifications for AE, SE and VR. Also fixes bugs and improves performance.
GNU General Public License v3.0
187 stars 46 forks source link

fix: fix vr ssgi reprojection #557

Closed Pentalimbed closed 1 month ago

Pentalimbed commented 1 month ago

not tested

FlayaN commented 1 month ago

This is basically reverting the change I did here https://github.com/Pentalimbed/skyrim-community-shaders/commit/731738fec874e447332bc2b70e285f0effc227cd , so maybe my fix wasn't the proper one. It did fix a issue tho, guess the proper fix is something inbetween?

Pentalimbed commented 1 month ago

This is basically reverting the change I did here https://github.com/Pentalimbed/skyrim-community-shaders/commit/731738fec874e447332bc2b70e285f0effc227cd , so maybe my fix wasn't the proper one. It did fix a issue tho, guess the proper fix is something inbetween?

What was that issue? It might just be canceling out two wrongs.

FlayaN commented 1 month ago

This is basically reverting the change I did here Pentalimbed@731738f , so maybe my fix wasn't the proper one. It did fix a issue tho, guess the proper fix is something inbetween?

What was that issue? It might just be canceling out two wrongs.

It was creating a lot of artifacts/noise issues. But maybe it was fixed another way and it can be reverted now 🤷

PR here https://github.com/doodlum/skyrim-community-shaders/pull/362

Here is when we talked about it on discord: https://discord.com/channels/1080142797870485606/1267250733435064360/1267797193696350280

alandtse commented 1 month ago

Yah, so the issue is screenpos already has the bufferdim multiplied into it. By multiplying again, you're just making all dimensions outside of the screen. This fix is the proper syntax.